Allow insert_all/upsert_all to use indexes with columns not in the same order as in :unique_by
#48018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Apr 27, 2023
Comment on lines
153
to
155
| match = Array(name_or_columns).map(&:to_s) | ||
|
|
||
| if index = unique_indexes.find { |i| match.include?(i.name) || i.columns == match } | ||
| if index = unique_indexes.find { |i| match.include?(i.name) || Array(i.columns).sort == match.sort } |
There was a problem hiding this comment.
can you move the match.sort outside the loop? Likely not a big deal in most cases, but it bother me 😅
There was a problem hiding this comment.
Updated.
So that's probably Shopify's scale taught to more carefully think about performance 😅
There was a problem hiding this comment.
Meh, the array is small, and it's very unlikely there's more than a dozen index on the table. It's just habit to never do unnecessary work however how small :).
byroot
approved these changes
Apr 27, 2023
…e same order as in `:unique_by`
fatkodima
force-pushed
the
insert_all-out-of-order-indexes
branch
from
ac4202f
to
45bff16
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small UX improvement.
Problem: If a user have a unique index on
(a, b)columns and usesModel.insert_all ..., unique_by: [:a, :b]everything works fine. But then he decides that a unique index on(b, a)would be better (because he is able to search onbcolumn via index). Now he must update all the uses of this index in allinsert_all/upsert_allcall in his code.The same can be applied to the composite primary keys (see line 157), but is it common to switch columns in primary keys?