Refactor Mysql2Adapter and TrilogyAdapter #48054
Merged
+132
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
cleanup-execute
branch
4 times, most recently
from
32e39c6
to
5b1e897
Compare
`#execute` is a public method and using it internaly forces us to expose private arguments and other dirty things. Other adapters don't do this, so this bring MySQL in line with others.
They were never meant to be public.
To be consistent with other adapters.
casperisfine
force-pushed
the
cleanup-execute
branch
from
5b1e897
to
eb3a174
Compare
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 5, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 6, 2023
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 6, 2023
(and attempt to have all method naming be as similar as possible to Rails 7.1)
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 6, 2023
(and attempt to have all method naming be as similar as possible to Rails 7.1)
lorint
added a commit
to lorint/activerecord-trilogy-adapter
that referenced
this pull request
Jul 19, 2023
(and attempt to have all method naming be as similar as possible to Rails 7.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly revolve around stopping to use
#executeas an internal method as it forces us to expose private parameters that aren't properly documented.Also do some minor cleanup in the recently merged
TrilogyAdapterto make it more consistent with other adapters.