Clean up shared DB statements code between Mysql2 and Trilogy #48112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
There is a lot of duplicated code between
ActiveRecord::ConnectionAdapters::MySQL::DatabaseStatements
(used byMysql2Adapter
) andActiveRecord::ConnectionAdapters::Trilogy::DatabaseStatements
. This PR introduces aDatabaseStatements
module at theAbstractMysqlAdapter
level, and moves this shared code into it.Detail
This PR makes two changes:
MySQL::DatabaseStatements
module toMysql2::DatabaseStatements
, since it's Mysql2-specific rather than MySQL specific. I did this because I'd like to useMySQL::DatabaseStatements
to hold shared database statement logic for all MySQL-compatible adapters.ActiveRecord::ConnectionAdapters::MySQL::DatabaseStatements
module. This involves removing some code that was in theTrilogyAdapter
that ought to have lived in theTrilogy::DatabaseStatements
module (e.g. multi-statement support).Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]