Fix chmod race condition when generating key #48141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 let's the the Thor feature merged and released, and then we can merge this. |
|
@skipkayhil please update this PR to use thor main |
Encrypted keys were updated [previously][1] to restrict other users from reading the file by default. However, there is a brief period of time between an encrypted key being created and its permissions being set to 0600. This means that it is possible for another user to read that file during that time. This commit fixes that issue by setting the desired permissions when the file is created. The ability to use the `perm` option was added in Thor 1.2.2 so the minimum version was updated in the Railties gemspec. [1]: 4c6c357
skipkayhil
force-pushed
the
hm-fix-chmod-race
branch
from
4ce213f
to
3ae8f4d
Compare
|
Thank you all for the reviews, I've updated the PR to require the newly released Thor 1.2.2 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #48135
Encrypted keys were updated previously to restrict other users from reading the file by default. However, there is a brief period of time between an encrypted key being created and its permissions being set to 0600. This means that it is possible for another user to read that file during that time.
Detail
This commit fixes that issue by setting the desired permissions when the file is created. The ability to use the
permoption was added in Thor 1.2.2 so the minimum version was updated in the Railties gemspec.Additional information
I've pointed this at my branch of Thor to show that rails/thor#820 would enable fixing this, but that would have to be changed to merge this.Done!Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]