Import rails-bin linter to rails internal tools lib

[zzak]

Alternative to #47813 to import the linter files directly to Rails source tree

$ zzak@mbp16 rails % ruby -v
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]



$ zzak@mbp16 rails % bundle exec tools/check-changelogs .
.............

13 changelogs inspected, 0 offenses detected



$ zzak@mbp16 rails % bundle exec tools/check-config-docs .



$ zzak@mbp16 rails % bundle exec tools/check-links .
https://edgeapi.rubyonrails.org/classes/ActiveSupport/MessageEncryptor.html#method-i-encrypt_and_sign

[skipkayhil]

I think I'd prefer importing rail_inspector just because the scripts were all combined into the single Thor entrypoint. If you think check-links is valuable I can add that to rail_inspector as that is currently missing. I think regen-dummy could also be worth importing, but it seems less important due to Rafael's comment: #47259 (comment)

Something else that probably needs to be done is better namespacing of the modules. I'm realizing now that these are all in the global namespace so it may be better to nest them when running in the context of a larger Gemfile. (I've opened an issue for that here: skipkayhil/rail_inspector#2)

Edit: I'm also noticing that this fails Rails' rubocop. Opened an issue for that too: skipkayhil/rail_inspector#3

Ah something else: I would be disappointed if we lose the changelog tests. They've been really useful in ensuring changes don't regress. With that being said, I don't know what running those tests in CI here would look like. I'm assuming it would be a Github Action and they should also probably only run if these files are being changed

[skipkayhil]

I think all of the visitors ended up duplicated under tools/lint

[skipkayhil]

I opened some example PRs on my fork to show that the rail_inspector.yml workflow will only run if the folder is touched (and in addition, since the whole workflow is skipped it won't show up in the job list either):
skipkayhil#3 <- no change, no rail_inspector workflow
skipkayhil#4 <- folder has change, rail_inspector workflow is run

Edit: hmm, looks like putting it in the Gemfile may not work...

[zzak]

I'm wondering if we need to add this workflow if we're going to move this to buildkite soon anyways 🤔