Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer method names for :*-method: directives [ci-skip] #48253

Merged

Conversation

p8
Copy link
Member

@p8 p8 commented May 18, 2023

The :method: and :singleton-method: directives infer the method name by looking at the token after the identifier.
So we don't need to specify them.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

The :method: and :singleton-method: directives infer the method name
by looking at the token after the identifier.
So we don't need to specify them.
@p8 p8 merged commit 2e181b1 into rails:main May 18, 2023
8 checks passed
@p8 p8 deleted the activestorage/method-directives-infer-method-names branch May 18, 2023 19:16
@p8
Copy link
Member Author

p8 commented May 18, 2023

Thanks @skipkayhil !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants