Handle sanitize_options
in simple_format
helper
#48355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
We needed to open the links in a new window along with the
simple_format
fromActionView
already used on the project. The problem is that Rails removes target="_blank" by default.This pull request is based on @Rubyist007 solution.
I noticed that
simple_format
uses sanitize, but doesn't allow options for this, however, adding the extra sanitize options such asattributes: %w[target href]
will resolve my issue.rails/actionview/lib/action_view/helpers/text_helper.rb
Line 321 in fa77687
Details
This Pull Request introduces
sanitize_options
- Any extra options you want appending to the sanitize for thesimple_format
helper.