Possibly clearer way of getting rid of ` and " #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incidentally it's also faster...
>> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.tr('`"', "") } }
=> 0.7388770580291748
>> a = 'hello "id` world'; Benchmark.realtime { 500_000.times { a.gsub(/[`"]/, "") } }
=> 1.7843739986419678
|
What about String#delete? |
|
RAILS IS GONNA BE SO FAST :) I love it. |
|
Haha! I hope 4.0 will be a lot faster :) |
|
Better, thanks! |
fxn
added a commit
that referenced
this pull request
Mar 28, 2012
Possibly clearer way of getting rid of ` and "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
You may find String#tr clearer than String#gsub in this case (YMMV)
Incidentally it's also faster...
>> a = 'hello "id
world'; Benchmark.realtime { 500_000.times { a.tr('"', "") } }=> 0.7388770580291748
>> a = 'hello "id
world'; Benchmark.realtime { 500_000.times { a.gsub(/["]/, "") } }=> 1.7843739986419678
Best,
Seamus