Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap Arel.sql to avoid error in doc of insert_all, upsert_all #48448

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

a5-stable
Copy link
Contributor

@a5-stable a5-stable commented Jun 11, 2023

Motivation / Background

An error will be raised when following the instructions in the document as is, so surrounded it with Arel.sql.

result = Book.insert_all! [{ name: "Rework", author_id: 1 }], returning: "id, name as new_name"
#=> Dangerous query method (method whose arguments are used as raw SQL) called: id, name as new_name. Known-safe values can be passed by wrapping them in Arel.sql(). (ArgumentError)   

Detail

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@a5-stable a5-stable changed the title wrap Arel.sql to avoid error wrap Arel.sql to avoid error in doc of insert_all, upsert_all Jun 11, 2023
@guilleiguaran guilleiguaran merged commit 3f0971d into rails:main Jun 11, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants