Do not revalidate encrypted attribute with current encrypted_type

[iamradioactive]

Motivation / Background

Fixes #48445
Fixes #48248

As per the current behaviour, Two queries are being fired to validate uniqueness of an encrypted attribute even in cases when encrypted_type.previous_types is nil. An additional query with the current encrypted/ciphered value should not be fired.

Detail

This PR updates the loop in ExtendedDeterministicUniquenessValidator to iterate over encrypted_type.previous_types only i.e. to exclude the current encrypted_type.

Additional information

For Additional context Please refer to #48445

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[jorgemanrubia]

Great work tracking this one down @iamradioactive 🙏

[ghiculescu]

@iamradioactive do you mind adding Fixes #48248 to your PR body? I confirmed this will also fix #48248

[nvasilevski]

to iterate over encrypted_type.previous_types only i.e. to exclude the current encrypted_type.

Just for my own understanding, by dropping encrypted_type from the list, are we saying that we deliberately don't want to validate encrypted_type or it will still be validated because it will be included in encrypted_type? Thanks

The change itself looks clear!

Upd: I think I found the answer in one of the issues and we deliberately remove the encrypted_type from the list as it is redundant to validate it

[iamradioactive]

@iamradioactive do you mind adding Fixes #48248 to your PR body? I confirmed this will also fix #48248

@ghiculescu , Seems like it's already added. Thanks @byroot

[ghiculescu]

Thanks for the fix @iamradioactive 👏