Remove no connection primary key test #48488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was added in rails@b3407c8 at a time when Rails was reading the `primary_keys` off a hash stored on `connection`. We no longer do that in Active Record so this test isn't really necessary. I'm removing it because it was flaky. I attempted to fix it in rails#48473 but realized today it's not testing the same thing it was before. After discussing it with Matthew, I've decided to remove it.
|
@eileencodes Do you think we should remove the test in |
|
Like the golden rule of irc, don't ask to submit a patch, just send it. So now there is #48697, I thought it's good to backport changes like this to help improve the stability of those branches. Feel free to close if you feel otherwise 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added in b3407c8 at a time when Rails was reading the
primary_keysoff a hash stored onconnection. We no longer do that in Active Record so this test isn't really necessary. I'm removing it because it was flaky. I attempted to fix it in #48473 but realized today it's not testing the same thing it was before. After discussing it with Matthew, I've decided to remove it.