Don't show secrets for MessageEncryptor#inspect #48499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
activesupport/inspect-message-encryptor
branch
from
b5b628d
to
3d3cb04
Compare
|
Thanks @p8, can you fix the conflicts? |
p8
force-pushed
the
activesupport/inspect-message-encryptor
branch
from
3d3cb04
to
34fc51c
Compare
If anyone calls a message encryptor in the console it will show the secret of the encryptor. By overriding the `inspect` method to only show the class name we can avoid accidentally outputting sensitive information. Before: ```ruby ActiveSupport::MessageEncryptor.new(secret, cipher: "aes-256-gcm").inspect "#<ActiveSupport::MessageEncryptor:0x0000000104888038 ... @secret=\"\\xAF\\bFh]LV}q\\nl\\xB2U\\xB3 ... >" ``` After: ```ruby ActiveSupport::MessageEncryptor.new(secret, cipher: "aes-256-gcm").inspect "#<ActiveSupport::MessageEncryptor:0x0000000104888038>" ```
p8
force-pushed
the
activesupport/inspect-message-encryptor
branch
from
34fc51c
to
3f1526a
Compare
|
Thanks @eileencodes . I've rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone calls a message encryptor in the console it will show the secret of the encryptor.
By overriding the
inspectmethod to only show the class name we can avoid accidentally outputting sensitive information.Before:
After:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]