Remove unnecessary setters of use_transactional_tests
#48504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
remove-unnecessary-use_transactional_tests
branch
from
ee0bf8f
to
45cb471
Compare
I've removed `self.use_transactional_tests = false` from the tests here as they don't appear to be necessary. They were likely added when other tests were copied or just an assumption they were needed.
eileencodes
force-pushed
the
remove-unnecessary-use_transactional_tests
branch
from
45cb471
to
96a2a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed
self.use_transactional_tests = falsefrom the tests here as they don't appear to be necessary. They were likely added when other tests were copied or just an assumption they were needed.