Update Active Job testing guide #48526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing guide for Active Job currently implies that when you queue a job it will be performed. This isn't true; by default jobs are enqueued, not performed. This PR fleshes out the docs a bit to show both examples, and adds a test to confirm the default behaviour.
zzak
approved these changes
Jun 20, 2023
|
@zzak guessing you can't merge this because of the test? |
|
@ghiculescu No, I generally let the author merge once they have commit to merge their own PR. 🙏 |
|
I don’t have commit @zzak |
|
Whoops, I thought I've seen you merge PRs before! I will merge this then 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing guide for Active Job currently implies that when you queue a job it will be performed:
This isn't true; by default jobs are enqueued, not performed.
This PR fleshes out the docs a bit to show both examples, and adds a test to confirm the default behaviour.