Disallow id as an enum value in Active Record
#48527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
force-pushed
the
active-record-enum-id
branch
from
bb610c8
to
e257236
Compare
Fixes rails#48524 The test case in the issue breaks because `value.respond_to?(:id)` returns true [here](https://github.com/rails/rails/blob/51f2e2f80b86e0c3769cf5272b7d97035730f19d/activerecord/lib/active_record/relation/predicate_builder.rb#L58). This effectively adds a default scope to queries where it shouldn't. There might be a way to fix this in Active Record but I'd be surprised if nothing else breaks from defining `id` instance and class methods. I think it is simpler to not allow it as a value since it really should be treated as a reserved method.
ghiculescu
force-pushed
the
active-record-enum-id
branch
from
e257236
to
a22b942
Compare
skipkayhil
added a commit
to skipkayhil/rails
that referenced
this pull request
Jun 20, 2023
…enum-id" This reverts commit 8b36095, reversing changes made to e05245d. Railties tests have been failing since this change. The issue is that calling `primary_key` as the model is loaded requires either a connection to the database or a populated schema cache. This becomes an issue when an app loads models that do not have underlying tables, as shown in the failing Railties tests. When eager loading an app using `rails/all`, `ActionMailbox::InboundEmail` will be loaded whether or not `rails g action_mailbox:install` has been run. This means the `primary_key` for `InboundEmail` will not be in the schema cache and a database connection will be required to boot the app.
guilleiguaran
added a commit
that referenced
this pull request
Jun 20, 2023
Revert "Merge pull request #48527 from ghiculescu/active-record-enum-id"
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Jun 20, 2023
…-record-enum-id""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48524
The test case in the issue breaks because
value.respond_to?(:id)returns true here. This effectively adds a default scope to queries where it shouldn't.There might be a way to fix this in Active Record but I'd be surprised if nothing else breaks from defining
idinstance and class methods. I think it is simpler to not allow it as a value since it really should be treated as a reserved method.You can use
_prefix: trueto work around this if you want to useidas a value.