Revert "Merge pull request #48527 from ghiculescu/active-record-enum-id" #48534
Conversation
…enum-id" This reverts commit 8b36095, reversing changes made to e05245d. Railties tests have been failing since this change. The issue is that calling `primary_key` as the model is loaded requires either a connection to the database or a populated schema cache. This becomes an issue when an app loads models that do not have underlying tables, as shown in the failing Railties tests. When eager loading an app using `rails/all`, `ActionMailbox::InboundEmail` will be loaded whether or not `rails g action_mailbox:install` has been run. This means the `primary_key` for `InboundEmail` will not be in the schema cache and a database connection will be required to boot the app.
|
Why is |
All models in engines using (kind of related to the conversation we were having about Engines potentially needing their own loader so we can remove the dummy apps... although I think even if engines had their own loader that still wouldn't separate whether the migration for those models has been run in an app) |
|
Ah ok. I thought this was special for that model, but it is really all models that use |
|
Ahhh sorry I saw those tests but it didn't connect that they were related to this. Let me give this another try. |
|
The original version of my PR checked for |
Motivation / Background
Railties tests have been failing since this change. The issue is that calling
primary_keyas the model is loaded requires either a connection to the database or a populated schema cache. This becomes an issue when an app loads models that do not have underlying tables, as shown in the failing Railties tests.When eager loading an app using
rails/all,ActionMailbox::InboundEmailwill be loaded whether or notrails g action_mailbox:installhas been run. This means theprimary_keyforInboundEmailwill not be in the schema cache and a database connection will be required to boot the app.Detail
This reverts commit 8b36095, reversing changes made to e05245d.
Additional information
Example failures:
Ref #48524
Ref #48527
cc @ghiculescu @guilleiguaran