Fix EncryptedConfiguration not behaving like Hash #48556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `EncryptedConfiguration` was [updated][1] to use `InheritableOptions` so that keys could be called like methods. It was later [updated again][2] to ensure that it behaved both like a `Hash` and `OrderedOptions`. In this second change, the `InheritableOptions` instance was accidentally nested with another `InheritableOptions` instance. This continued to mostly work as expected because `InheritableOptions` will fall back to the inner `InheritableOptions` when the outer one doesn't have a key. However, any methods that try to treat the outer `InheritableOptions` like it should know about all of its keys will fail (for example, `#keys`, `#to_h`, `#to_json`, etc.) This commit fixes the issue by removing the extraneous outer `InheritableOptions` instance. [1]: a6a9fed [2]: 80585da
This was referenced Jun 22, 2023
|
Thanks a lot, it works >> Rails.application.credentials.to_h
=>
{:secret_key_base=> ...
... |
|
works great but maybe >> Rails.application.credentials
=> #<ActiveSupport::EncryptedConfiguration:0x0000000000a668>coudl be improved? |
This is actually intentional, it was just changed last week in #48498 |
|
Ok sure, I understand |
|
should we include this in the CHANGELOG for 7.1 if it's already present in the CHANGELOG for 7.0? (#48557) |
|
Yes, the 7.1.0 changelog is relative to 7.0.0, not 7.0.latest. |
|
thx you all rock, and I'm using main so I will get it after the next bundle update :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #48554
Previously,
EncryptedConfigurationwas updated to useInheritableOptionsso that keys could be called like methods. It was later updated again to ensure that it behaved both like aHashandOrderedOptions. In this second change, theInheritableOptionsinstance was accidentally nested with anotherInheritableOptionsinstance.This continued to mostly work as expected because
InheritableOptionswill fall back to the innerInheritableOptionswhen the outer one doesn't have a key. However, any methods that try to treat the outerInheritableOptionslike it should know about all of its keys will fail (for example,#keys,#to_h,#to_json, etc.)Detail
This commit fixes the issue by removing the extraneous outer
InheritableOptionsinstance.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]