Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敆 Remove RDoc auto-link from Rails module everywhere #48563

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

zzak
Copy link
Member

@zzak zzak commented Jun 23, 2023

This patch was sitting half-baked on my machine, so I decided to just finish it and remove these links which could be confusing to readers who end up on the Rails module not knowing it's purpose.

There are other similar namespaces that I'd like to to the same, but I wonder if there is a way to prevent auto-linking for a deny-listed set of modules with SDoc.

  • Hash
  • Mail
  • Digest
  • API
  • Time
  • Method

Just to name a few that I spotted when doing this.

Realizing this is a cosmetic change, but the value of potentially saving an early developer time possibly wasted on reading the Rails module is worth it IMO. And also using this as an opportunity to let others know about the remaining namespaces that could use the same treatment. 馃檹

@zzak zzak merged commit 5899ada into rails:main Jun 23, 2023
9 checks passed
@zzak zzak deleted the unlink-rails-module branch June 23, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant