Fix Active Record encryption not picking up encryption settings with eager-loading #48577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
changed the title
jorgemanrubia
changed the title
jorgemanrubia
force-pushed
the
eager-load-ar-encryption
branch
from
83e9e19
to
ed9c45c
Compare
jorgemanrubia
force-pushed
the
eager-load-ar-encryption
branch
from
ed9c45c
to
63646ea
Compare
…eager-loading This deals with a problem where, when eager-loading is enabled, Active Record fails to pick up settings affecting encryption schemes. The solution here is to resolve encryption schemes lazily, when the attribute type is used. Follow-up from rails#48530 Closes rails#48204 (comment)
jorgemanrubia
force-pushed
the
eager-load-ar-encryption
branch
from
63646ea
to
219eb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with a problem where, when eager-loading is enabled, Active Record fails to pick up settings affecting encryption schemes.
The solution here is to resolve encryption schemes lazily, when the attribute type is used.
Follow-up to #48530
Fixes #48204 (comment)
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]