Fix flaky tests without guaranteed sort #48580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test assertions rely on database queries that lack an ORDER BY statement. On occasion the database will return results from these queries in an unexpected order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
These test assertions rely on database queries that lack an ORDER BY statement. On occasion the database will return results from these queries in an unexpected order resulting in a flaky test.
Additional information
Further Reading... https://www.simplethread.com/chaos-order-randomizing-queries-uncover-order-dependency/
Here's the hacked together code (edits done via vim macros) I used to flush these out... main...abaldwin88:rails:chaos_order