Active Job: async adapter should always run jobs immediately if immediate set
#48626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ghiculescu
force-pushed
the
active-job-async-test
branch
2 times, most recently
from
1771d22
to
85fc8dc
Compare
ghiculescu
commented
Jul 2, 2023
| @@ -95,7 +95,7 @@ def enqueue(job, queue_name:) | |||
|
|
|||
| def enqueue_at(job, timestamp, queue_name:) | |||
| delay = timestamp - Time.current.to_f | |||
| if delay > 0 | |||
| if !immediate && delay > 0 | |||
ghiculescu
commented
Jul 2, 2023
| end | ||
| assert_match(/Stopped retrying RetryJob \(Job ID: .*?\) due to a CustomCatchError.*, which reoccurred on \d+ attempts\./, @logger.messages) |
There was a problem hiding this comment.
Moving this assertion out of the block fixes the backtrace that shows if this test fails. Not strictly related to this PR, but this is how I discovered the issue.
ghiculescu
commented
Jul 2, 2023
|
|
||
| test "in immediate run, enqueue with wait: runs immediately" do | ||
| HelloJob.set(wait_until: Date.tomorrow.noon).perform_later "Alex" | ||
| assert_match(/Alex/, JobBuffer.last_value) |
There was a problem hiding this comment.
This fails without the fix.
skipkayhil
reviewed
Jul 2, 2023
…mediate` set This is an internal fix, not user facing. I noticed it while working on rails#48585. The `async` adapter has an `immediate` option, which should only be used in tests. This option should tell the adapter to run jobs inline. This works correctly with `perform_later`, but it does not work with `enqueue_at`, which is what other internal mechanisms such as `retry_job` use. This PR fixes this bug.
ghiculescu
force-pushed
the
active-job-async-test
branch
from
85fc8dc
to
639dab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal fix, not user facing. I noticed it while working on #48585.
The
asyncadapter has animmediateoption, which should only be used in tests. This option should tell the adapter to run jobs inline. This works correctly withperform_later, but it does not work withenqueue_at, which is what other internal mechanisms such asretry_jobuse.This PR fixes this bug.