Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from encryption tests #48655

Merged
merged 1 commit into from Jul 5, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Jul 5, 2023

The Book model isn't used in the EncryptionSchemesTest.
SchemeTest#declare_and_use_class is declared but never used.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

The Book model isn't used in the EncryptionSchemesTest.
`SchemeTest#declare_and_use_class` is declared but never used.
@yahonda yahonda merged commit f1c51f1 into rails:main Jul 5, 2023
9 checks passed
@p8 p8 deleted the activerecord/remove-unused-code branch August 1, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants