Lay groundwork for replaceable cache compressor #48673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falsy `:compress_threshold` values are not supported, so we can always set the default value.
`NullCoder` is functionally equivalent to the `:passthrough` coder. Additionally, `NullCoder` was added in c4845aa to serve as the default coder for `MemCacheStore`, but `MemCacheStore` now uses `:passthrough` as its (legacy) default coder.
`activesupport/lib/active_support/cache.rb` is already rather long, and having a separate file allows subclasses of `Cache::Entry` to be defined without first requiring `activesupport/lib/active_support/cache.rb`.
This makes it easier to add new base options with default values to `Cache::Store`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts several small changes from #48451 in order to make #48451 easier to review.