Add a load hook for ActiveModel::Model
#48698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
ActiveRecord::Base
has a dedicated ActiveSupport load hook. This adds a hook forActiveModel::Model
, so that when ActiveModel is being used without ActiveRecord, it can still be modified.Kredis would be able to use this hook here. Instead of:
we could write
This change would help fix a reported issue at rails/kredis#60.
Detail
See the motivating issue at rails/kredis#60 and additional comment by @fxn here: rails/kredis#60 (comment)
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]