Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc and spec cookies.delete returning the cookie value #48719

Merged
merged 1 commit into from Jul 13, 2023

Conversation

henrik
Copy link
Contributor

@henrik henrik commented Jul 12, 2023

Doc and spec cookies.delete returning the cookie value.

I didn't want to rely on this behaviour since it was undocumented and (AFAIK) untested.

@rails-bot rails-bot bot added the actionpack label Jul 12, 2023
@henrik henrik force-pushed the doc-and-spec-cookies-delete-rval branch from ba2d1ba to cf166fb Compare July 12, 2023 11:08
@guilleiguaran guilleiguaran merged commit 7d49d7b into rails:main Jul 13, 2023
9 checks passed
@henrik
Copy link
Contributor Author

henrik commented Jul 13, 2023

Thank you, @guilleiguaran! ⭐

@henrik henrik deleted the doc-and-spec-cookies-delete-rval branch July 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants