Discard connection in ensure, not rescue #48740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially Fixes rails#48164. Followup to rails#48200. `within_new_transaction` currently discards connections if an error is raised which may have left the connection in a transaction. This change updates that logic to discard connections in an `ensure` block to handle cases where an error is not raised, for instance if the thread is killed.
nicholasdower
commented
Jul 15, 2023
|
|
||
| Connections are now discarded in this case. | ||
|
|
||
| *Nick Dower* |
There was a problem hiding this comment.
Note that there is already a changelog entry on line 216 for the previous change. I wasn't sure whether it was ok to simply update that entry. I'm also not sure this fix warrants a changelog entry.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Partially Fixes #48164. Followup to #48200.
Detail
within_new_transactioncurrently discards connections if an error is raised which may have left the connection in a transaction. This change updates that logic to discard connections in anensureblock to handle cases where an error is not raised, for instance if the thread is killed.Additional information
Replaces #48224.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]