Change load error messages to use Kernel#warn instead of $stderr.puts
#48777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts` When development tools try to load Rails components, they sometimes end up loading files that will error out since a dependency is missing. In these cases, the tooling can catch the error and change its behaviour. However, since the warning is printed directly to `$stderr`, the tooling cannot catch and suppress it easily, which ends up causing noise in the output of the tool. This change makes Rails print these warnings using `Kernel#warn` instead, which can be suppressed by the tooling.
|
Thanks @guilleiguaran for the fast merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the current method of printing directly to
$stderrfor load errors can be unnecessarily noisy.When development tools try to load Rails components, they sometimes end up loading files that will error out since a dependency is missing. In these cases, the tooling can catch the error and change its behaviour, but not suppress the message as easily.
Since the warning is printed directly to
$stderr, the tooling has to swap the stderr around to be able to suppress these messages, which is a quite finicky thing to do.This change makes Rails print these warnings using
Kernel#warninstead, which can be quite easily suppressed by any tooling.Detail
This Pull Request changes the way load error messages are printed from using
$stderr.putstoKernel#warn.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]