Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] ActiveStorage guides don't recommend using a deprecated config #48784

Merged
merged 1 commit into from Jul 21, 2023

Conversation

santib
Copy link
Contributor

@santib santib commented Jul 21, 2023

Motivation / Background

This Pull Request has been created because recently a PR was merged suggesting to use a configuration that was deprecated and will be removed in the next minor release of Rails.

Detail

This Pull Request adjusts the ActiveStorage guides to not mention the deprecated configuration.

Additional information

Deprecation of replace_on_assign_to_many: #42596
Removal of replace_on_assign_to_many: c720b7e

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

cc @adrianna-chang-shopify

@rails-bot rails-bot bot added the docs label Jul 21, 2023
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@adrianna-chang-shopify adrianna-chang-shopify merged commit 04c97ae into rails:main Jul 21, 2023
@santib
Copy link
Contributor Author

santib commented Jul 21, 2023

Thanks to you and to @siaw23 for the newsletter which brought this to my attention 😄

@santib santib deleted the fix-active-storage-guides branch July 21, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants