Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] Added some grammatical changes and missing punctuations #48806

Merged
merged 1 commit into from Aug 1, 2023
Merged

[skip ci] Added some grammatical changes and missing punctuations #48806

merged 1 commit into from Aug 1, 2023

Conversation

akhilgkrishnan
Copy link
Member

Detail

This PR includes grammatical changes and added some missing punctuation to the active record multiple database guide.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Jul 26, 2023
@akhilgkrishnan akhilgkrishnan changed the title Added some grammatical changes and puntuations [ci-skip] Added some grammatical changes and puntuations Jul 26, 2023
@akhilgkrishnan akhilgkrishnan changed the title [ci-skip] Added some grammatical changes and puntuations Added some grammatical changes and punctuations Jul 26, 2023
@akhilgkrishnan akhilgkrishnan changed the title Added some grammatical changes and punctuations Added some grammatical changes and missing punctuations Jul 26, 2023
@akhilgkrishnan akhilgkrishnan force-pushed the punctuation-and-grammer-fix branch 2 times, most recently from 88776c3 to 8b9acac Compare July 31, 2023 03:24
@akhilgkrishnan akhilgkrishnan changed the title Added some grammatical changes and missing punctuations [skip ci] Added some grammatical changes and missing punctuations Jul 31, 2023
@akhilgkrishnan
Copy link
Member Author

@skipkayhil Updated the suggested changes.

skipkayhil
skipkayhil approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@skipkayhil skipkayhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good to me, but we'll someone else to be able to merge

@akhilgkrishnan akhilgkrishnan force-pushed the punctuation-and-grammer-fix branch 2 times, most recently from b64a1c3 to ee9c7da Compare August 1, 2023 01:57
@ghiculescu ghiculescu added the ready PRs ready to merge label Aug 1, 2023
@akhilgkrishnan
[skip ci] Added some grammatical changes and puntuations
73e6ddc 
fixed the line length

Alignment fix

Alignment fix

Update guides/source/active_record_multiple_databases.md

Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>

Update guides/source/active_record_multiple_databases.md

Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>

Update guides/source/active_record_multiple_databases.md

Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>

Update guides/source/active_record_multiple_databases.md

Co-authored-by: Alex Ghiculescu <alex@tanda.co>

updated essential with important
@rafaelfranca rafaelfranca merged commit 3f500d7 into rails:main Aug 1, 2023
@akhilgkrishnan akhilgkrishnan deleted the punctuation-and-grammer-fix branch August 2, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipkayhil skipkayhil skipkayhil approved these changes

@ghiculescu ghiculescu Awaiting requested review from ghiculescu

Assignees
No one assigned
Labels
docs ready PRs ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhilgkrishnan @ghiculescu @skipkayhil @rafaelfranca