Make ActiveResource error parsing interoperate with ActionController #4881
+83
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
added a commit
that referenced
this pull request
Feb 5, 2012
Make ActiveResource error parsing interoperate with ActionController. Closes #4881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revised and expanded version of the solution in pull request #3046. I've added deprecated paths for older-style responses and updated the documentation.
To summarize the discussion, ActiveResource currently fails to correctly parse errors issued by
ActionController::Responderwhen using the default JSON format. This patch corrects that behavior, and includes handling for both the previously documented format (an "errors" key, with an array of messages) and the previous behavior ofActionController::Responder(a hash of attributes and errors, no root key) that was corrected in #3272 for Rails 3.2.