Add Rack::Lint to ActionDispatch::Callbacks tests #48810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
To ensure Rails is and remains compliant with the Rack 3 spec we can add
Rack::Lint
to the Rails middleware tests.This adds additional test coverage for ActionDispatch::Callbacks by validating that its input and output follow the Rack SPEC.
Detail
ActionDispatch::Callbacks
makes no changes to the input or output of the Rack app itself, so these tests are trivial.Additional information
The
"rack.input" => StringIO.new("")
header value raised the following error:Since this header is not required for the test, it is now removed.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]