Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to audio analyzer metadata #48823

Merged
merged 1 commit into from Jul 28, 2023

Conversation

Gambitboy
Copy link

Motivation / Background

This Pull Request has been created because I'm creating a rails api that allows you to upload mp3 files and serves them back to TV devices. Instead of filling in the data manually I need to analyze the files and access the tags metadata object which will include things like 'title', 'artists' and more.

Detail

This PR adds a tags key in the metadata hash output by the audio analyzer with the blob tags.

Additional information

N/A

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@Gambitboy Gambitboy force-pushed the audio_analyzer_metadata_tags branch from 20e2634 to dc4eb0f Compare July 27, 2023 08:31
@guilleiguaran guilleiguaran merged commit 814f8ee into rails:main Jul 28, 2023
9 checks passed
@Gambitboy
Copy link
Author

Hi, what is the normal timeline for something like this to be released?

I need this bit of code for my current project.
Is there a way for me to temporarily monkey patch it into my project?

@skipkayhil
Copy link
Member

Hi, what is the normal timeline for something like this to be released?

New features will be released in 7.1. In the meantime you could point your Gemfile at main or monkey patch as you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants