Add Rack::Lint to ActionDispatch::Reloader tests #48846

akhilgkrishnan · 2023-07-29T08:52:41Z

This adds test coverage to ActionDispatch::Reloader to validate that its behavior conforms to Rack SPEC.

This adds additional test coverage to ActionDispatch::Loader to validate that its input and output follow the Rack SPEC.

This also removes some tests that were asserting the body object passed to ActionDispatch::Loader and not the Rack SPEC. See also rack/rack#2100.
ref: https://github.com/rails/rails/pull/48825/files#r1275947386

Before submitting the PR make sure the following are checked:

This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
Tests are added or updated if you fix a bug or add a feature.
CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

akhilgkrishnan · 2023-07-29T08:53:31Z

actionpack/test/dispatch/reloader_test.rb

      resp[2].close
    end
    assert_equal 3, i
    assert_equal 3, j
  end

-  def test_returned_body_object_behaves_like_underlying_object


Ref: https://github.com/rails/rails/pull/48825/files#r1275947386

akhilgkrishnan · 2023-07-29T08:53:40Z

actionpack/test/dispatch/reloader_test.rb

    end
    body.close
    assert close_called
  end

-  def test_returned_body_object_responds_to_all_methods_supported_by_underlying_object


https://github.com/rails/rails/pull/48825/files#r1275947386

Add Rack::Lint to ActionDispatch::Reloader tests

15bca6e

rails-bot bot added the actionpack label Jul 29, 2023

akhilgkrishnan commented Jul 29, 2023

View reviewed changes

guilleiguaran merged commit 127138c into rails:main Jul 30, 2023
9 checks passed

akhilgkrishnan deleted the add-rack-lint-to-reloader-test branch July 31, 2023 05:58

Provide feedback