Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rack::Lint to DebugExceptions missing test #48855

Conversation

akhilgkrishnan
Copy link
Member

@akhilgkrishnan akhilgkrishnan commented Jul 31, 2023

Motivation / Background

#48837 missed adding Rack::Lint spec to one of the tests in DebugExceptionsTest.

Detail

This PR adds the Rack::Lint spec for one of tests that was missed in #48837

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the actionpack label Jul 31, 2023
@guilleiguaran guilleiguaran merged commit 4c9a990 into rails:main Aug 1, 2023
9 checks passed
@akhilgkrishnan akhilgkrishnan deleted the add-rack-link-to-debug-exception-missing-test branch August 1, 2023 17:56
@skipkayhil
Copy link
Member

Thanks! Linking to #48874 to keep everything organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants