Change the devcontainer configuration to use docker compose instead of collocated services #48891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make easier to make sure the service is running when the development container is started. Before after the first time the container was created, if it was restarted you needed to run the boot.sh script manually to start the service.
rafaelfranca
force-pushed
the
rm-devcontainer-right
branch
from
3888eb9
to
a96c371
Compare
rafaelfranca
added a commit
that referenced
this pull request
Aug 8, 2023
Change the devcontainer configuration to use docker compose instead of collocated services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not only match most of the CI configuration but will provide better experience for users of those containers.
Before after the first time the container was created, if it was restarted you needed to run the boot.sh script manually to start those services. Now, docker compose will make sure the services are running and there is no need to run.
boot.shagain.