Changing active model dirty module helper method to more appropriate hel... #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed it is better but if we are going to use present?, we need to require |
|
Its already loaded. Have tested the test cases which is running fine. |
|
Are you running the test case in isolation mode? |
|
Am running all the active model test cases. |
|
You need to run them in isolation in order to catch missing requires. In any case, we should just add the missing require. |
|
will do if it is missed |
added 2 commits
February 6, 2012 15:51
…helper with hash helper
…into refactor_dirty_module
|
I made another pull request for this issue, please refer #4904 |
ask4prasath
pushed a commit
to ask4prasath/rails
that referenced
this pull request
Feb 6, 2012
…method with helper rails#4903 Changing active model dirty module helper method to more appropriate method with helper with Active Support Helper rails#4903 Changing active model dirty module helper method to more appropriate method with helper with Active Support Helper typo fixed rails#4903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing active model dirty module helper method to more appropriate helper method.