Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no _method input in form_for namespaced model #49053

Merged
merged 1 commit into from Aug 28, 2023

Conversation

skipkayhil
Copy link
Member

@skipkayhil skipkayhil commented Aug 28, 2023

Motivation / Background

Fixes #48789

This was originally added before Rails 7.0.0, but was broken before the official 7.0.0 release. Additionally, it was backported to 6-1-stable and so it first appeared in 6.1.5. It was also resolved later on main but in a backwards incompatible way.

Detail

This fixes the issue without any backwards compatibility changes so it can safely be applied to 7-0-stable and the behavior is consistent between 6-1-stable, 7-0-stable, and main.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

This was originally [added][1] before Rails 7.0.0, but was [broken][2]
before the official 7.0.0 release. Additionally, it was backported to
6-1-stable and so it first appeared in 6.1.5. It was also [resolved][3]
later on main but in a backwards incompatible way.

This fixes the issue without any backwards compatibility changes so it
can safely be applied to 7-0-stable and the behavior is consistent
between 6-1-stable, 7-0-stable, and main.

[1]: 58127ec
[2]: 269f672
[3]: 3404606
@rails-bot rails-bot bot added the actionview label Aug 28, 2023
@rafaelfranca rafaelfranca merged commit d0403d2 into rails:7-0-stable Aug 28, 2023
3 checks passed
@skipkayhil skipkayhil deleted the hm-fix-48789 branch August 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants