-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url_for method's behavior. GH #3684. #4908
Conversation
…on which starts with "/" from multiple nested controller. Closes rails#3864
Fix url_for method's behavior. GH #3684.
Fix url_for method's behavior. GH #3684.
Does this fix #2575? |
It seems that this problem is same one ;-) |
I've got no issue with this PR at all. It's good. Thanks! :) |
Great update guys - wonderful to see this fixed :-) Is it too much to ask to have it posted here when it is inserted into core? |
Oh, by the way, with core, I mean stable release |
I closed the other ticket and then realised I still had a monkeypatch there that was causing it to work regardless of your patch. I've just spent half an hour trying to get master branch working on my codebase and I'm giving up. I get so many dependancies failing in my Gemfile. I'm pretty certain that what you've got there will fix it, so I'm just going to leave the other ticket closed and I'll keep an eye on it. Thanks, @kennyj. |
@kennyj, sorry - could you put a PR for 3-2-stable too please so I can get rid of my monkey-patch? :) |
Sorry to jump on the end of this ticket but.. any idea why this would cause resolve/refinerycms#1383 ? |
Fix url_for method's behavior when it is passed with :controller option which starts with "/" in a multiple nested controller. Please see a testcase, and #3864
It seems that this problem is occured on 3-1-stable, 3-2-stable, and master.
Closes #3864