Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $global mistakenly left in test #49123

Merged
merged 1 commit into from Sep 4, 2023
Merged

Remove $global mistakenly left in test #49123

merged 1 commit into from Sep 4, 2023

Conversation

skipkayhil
Copy link
Member

Ref #49090

This was accidentally left in when this change was submitted to main. This was already addressed in the backport commit but this addresses it for main.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@skipkayhil
Remove $global mistakenly left in test
db1a353 
This was accidentally left in when this change was [submitted][1] to
main. This was already addressed in the backport commit but this
addresses it for main.

[1]: 57a9e25
akhilgkrishnan
akhilgkrishnan reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skipkayhil Why Buildkite is failing for all the PRs?

@guilleiguaran guilleiguaran merged commit bf9577e into rails:main Sep 4, 2023
3 of 4 checks passed
@skipkayhil skipkayhil deleted the hm-followup-49090 branch September 5, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan left review comments

Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skipkayhil @akhilgkrishnan @guilleiguaran