Fix in-place modification of shared _counter_cache_columns class attribute
#49136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ def self.add_counter_cache_callbacks(model, reflection) | |||
| } | |||
|
|
|||
| klass = reflection.class_name.safe_constantize | |||
| klass._counter_cache_columns << cache_column if klass && klass.respond_to?(:_counter_cache_columns) | |||
| klass._counter_cache_columns |= [cache_column] if klass && klass.respond_to?(:_counter_cache_columns) | |||
There was a problem hiding this comment.
@fatkodima Just curious to know, how this exactly fixes the issue. In both cases, we are appending the column to the _counter_cache_columns right?
There was a problem hiding this comment.
For << we modify the original object, but for |= we create a new object with the original contents and the new column and assign to the attribute (original object is intact).
|
Just to confirm, this fixes my original issue. That was a strange experience initially since it only reproduced when creating an elasticsearch index but the root cause was probably the models being accessed in a different order which makes a lot of sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49132.
_counter_cache_columnsclass attribute is defined onActiveRecord::Baseclass and all models share its value. We should not modify it in place, but reassign to it.