Remove internal usage of require_dependency #49139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
actionmailer/require-previews
branch
from
93c5b75
to
f9572aa
Compare
Since 6983a89 `require_dependency` is obsolete since Rails stopped supporting classic mode. It is only used by engines that need to support classic mode as well. We can safely remove internal usage of `require_dependency`. It was only used in the ActionMailer::Preview which is using just `require` anyway.
p8
force-pushed
the
actionmailer/require-previews
branch
from
f9572aa
to
6998747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require_dependencyis obsolete since Rails stopped supporting classic mode.It is only used by engines that need to support classic mode as well.
We can safely remove internal usage of
require_dependency.It was only used in the ActionMailer::Preview which ends up using just
requireanyway.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]