Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate configuration for sprockets if propshaft is used #49145

Merged
merged 1 commit into from Sep 5, 2023

Conversation

javierav
Copy link
Contributor

@javierav javierav commented Sep 5, 2023

Motivation / Background

This Pull Request has been created because currently, when a new rails project is initialized using propshaft, configuration for sprockets is generated in the file config/initializers/assets.rb.

# Precompile additional assets.
# application.js, application.css, and all non-JS/CSS in the app/assets
# folder are already added.
# Rails.application.config.assets.precompile += %w( admin.js admin.css )

Although this part of the code is generated with comments, it can mislead especially people who are less experts in the framework.

Detail

This Pull Request includes the necessary changes so that that part is not generated in the configuration file.

@rails-bot rails-bot bot added the railties label Sep 5, 2023
@rafaelfranca rafaelfranca merged commit fee7de5 into rails:main Sep 5, 2023
3 of 4 checks passed
@javierav javierav deleted the feature/assets-config branch January 12, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants