Just check the BigDecimal 3.1+ behavior at NumericalityValidationTest
#49152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare Ruby 3.4 will ship `bigdecimal` as bundled gem, `bigdecimal` has been added to Active Support runtime dependency via rails#49039 It will install BigDecimal version 3.1.4 or higher, so we just check the BigDecimal 3.1+ behavior at `NumericalityValidationTest`. Refer to rails#49039 ruby/bigdecimal#180 ruby/bigdecimal#70
4 tasks
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Sep 19, 2023
Follow up rails#49152 rails#49039 - `bigdecimal_to_d.rb` ``` require 'bigdecimal/util' p "Ruby version: #{RUBY_VERSION}" p "BigDecimal version: #{BigDecimal::VERSION}" p "123.455.to_d(5): #{123.455.to_d(5)}" ``` - Ruby 2.7 and 3.0 rounds down ``` $ ruby bigdecimal_to_d.rb "Ruby version: 2.7.8" "BigDecimal version: 2.0.0" "123.455.to_d(5): 0.12345e3" ``` ``` $ ruby bigdecimal_to_d.rb "Ruby version: 3.0.6" "BigDecimal version: 3.0.0" "123.455.to_d(5): 0.12345e3" ``` - Ruby 3.1 and 3.2 rounds up ``` $ ruby bigdecimal_to_d.rb "Ruby version: 3.1.4" "BigDecimal version: 3.1.1" "123.455.to_d(5): 0.12346e3" ``` ``` $ ruby bigdecimal_to_d.rb "Ruby version: 3.2.2" "BigDecimal version: 3.1.3" "123.455.to_d(5): 0.12346e3" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
To prepare Ruby 3.4 will ship
bigdecimalas bundled gem,bigdecimalhas been added to Active Support runtime dependency via #49039It will install BigDecimal version 3.1.4 or higher, so we just check the BigDecimal 3.1+ behavior at
NumericalityValidationTest.Detail
None
Additional information
Refer to
#49039
ruby/bigdecimal#180
ruby/bigdecimal#70
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]