Remove unused methods on ActiveStorage::Variant #49196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods were added in b221a4d But they don't seem to be used by Rails internally or have any tests, so I assume they were added by accident? As they both seem to be marked as :nodoc: on ActiveStorage::Blob, we can remove them without a deprecation warning. If we decide to keep these methods, they should be added to ActiveStorage::VariantWithRecord as well. No one complaining about there methods missing on ActiveStorage::VariantWithRecord is another reason these methods aren't used.
p8
force-pushed
the
activestorage/remove-unused-methods
branch
from
fe6bf74
to
1e23fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods were added in b221a4d But they don't seem to be used by Rails internally or have any tests, so I assume they were added by accident?
As they both seem to be marked as :nodoc: on ActiveStorage::Blob, we can remove them without a deprecation warning.
If we decide to keep these methods, they should be added to ActiveStorage::VariantWithRecord as well.
No one complaining about there methods missing on ActiveStorage::VariantWithRecord is another reason these methods aren't used.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]