Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore env files (except templates) #49278

Merged
merged 1 commit into from Sep 14, 2023
Merged

Ignore env files (except templates) #49278

merged 1 commit into from Sep 14, 2023

Conversation

dhh
Copy link
Member

@dhh dhh commented Sep 14, 2023

Help people avoid checking in .env files with potentially sensitive tokens.

@dhh
Ignore env files (except templates)
9d14f99 
Help prevent security issues out of the box.
@rails-bot rails-bot bot added the railties label Sep 14, 2023
rafaelfranca
rafaelfranca approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. It is a common error

@dhh dhh merged commit 7578618 into main Sep 14, 2023
6 of 7 checks passed
@dhh dhh deleted the ignore-env-files branch September 14, 2023 21:53
@skipkayhil
Copy link
Member

A similar change was proposed in #48940, should any of those other template types be allowed?

dhh added a commit that referenced this pull request Sep 14, 2023
@dhh
Remove duplication from #49278
83f36d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipkayhil skipkayhil skipkayhil left review comments

@rafaelfranca rafaelfranca rafaelfranca approved these changes

Assignees
No one assigned
Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhh @skipkayhil @rafaelfranca