This enhancement automatically updates the Dockerfile to the desired db.

[paulreece]

This enhancement automatically updates the Dockerfile to the desired db when using db:system:change.

It is currently implemented to update and change the following:

• sqlite3
• mysql
• postgresql
• trilogy

Please Advise:

I could only find oracle install information using yum.

I could not find reliable Dockerfile information on the following:

• sqlserver
• jdbc
• jdbcmysql
• jdbcpostgresql
• jdbdsqlite3

If one of the maintainers can tell me the desired config for the DB's that are not currently implemented I will add them. However if they are not seen as necessary at this point I will push up a commit removing the commented out lines containing them.

Motivation / Background

Fixes 49304.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[eileencodes]

Trilogy is just a different client/adapter for mysql, so it should use the same commands as mysql2.

[paulreece]

Trilogy is just a different client/adapter for mysql, so it should use the same commands as mysql2.

Just added this in! Thank you

[paulreece]

I added the default Dockerfile that's created for a new app in the fixtures directory within the /railties/test/fixtures directory as Dockerfile.test. This is then tested against my assertions in the tmp dir.

With this I now have functioning tests.

[guilleiguaran]

jdbc
jdbcmysql
jdbcpostgresql
jdbdsqlite3

I would expect someone using those adapters has JRuby and proper dependencies already so we don't need to do anything else for those cases.

[paulreece]

jdbc
jdbcmysql
jdbcpostgresql
jdbdsqlite3

I would expect someone using those adapters has JRuby and proper dependencies already so we don't need to do anything else for those cases.

Just removed these as well as oracle. Let me know if it needs any other adjustments.

[dhh]

Great work, @paulreece! Thanks for taking this on 👏