Cleaned up test that was missing regex escaping #49345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
changed the title
| else | ||
| assert_match(/WHERE "sharded_comments"."blog_id" IN \(.+\) AND "sharded_comments"."blog_post_id" IN \(.+\)/, sql) | ||
| end | ||
| c = Sharded::BlogPost.connection |
There was a problem hiding this comment.
Can we call this connection? Not sure the single letter / short variable name is of much help.
There was a problem hiding this comment.
I was following the convention used in other tests like https://github.com/rails/rails/blob/d56db8ff17cfdff94954e4b93b965e929df0ee63/activerecord/test/cases/batches_test.rb#L517C7-L517C7
I will change it to connection if needed.
There was a problem hiding this comment.
Cool, that's fine then. I looked at this one but hadn't checked other files. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Test in
activerecord/test/cases/associations/eager_test.rbis missing regular expression escaping. This causes issues for other adapters such as the SQL Server Active Record adapter (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter) where quoted table/column names use square brackets (eg: "[posts].[id]").Also, removed the adapter check and allowed the adapter to quote the table-column instead.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]