Actually upload the files when passed as File or Pathname #49381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #45606 We were storing the file metadata in Blob and Attachment but we were not actually uploading the files (into the file system for instance for disk storage). It was failing silently so I made it explicit what is accepted and what is unexpected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #45606
We were storing the file metadata in Blob and Attachment but we were not actually uploading the files (into the file system for instance for disk storage).
It was failing silently so I made it explicit what is accepted and what is unexpected
[Fix #issue-number]cc: @p8 @seanpdoyle @byroot @tenderlove @chaadow