Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Add 7.1 release notes for SQLite3 adapter improvements #49387

Merged
merged 1 commit into from Sep 26, 2023

Conversation

fractaledmind
Copy link
Contributor

Motivation / Background

I have been pushing to get the SQLite3 adapter in a stronger place in advance of the 7.1 release. All in all, I have opened 3 pull requests to bring larger, existing ActiveRecord features to the SQLite3Adapter:

In addition, I have also opened 3 additional pull requests to add some new, SQLite-specific features:

As of today (26-09-2023), 4 are merged (#49290, #49287, #49349, #49352) and 2 are still open (#49346, #49376)

I am presuming, however, the the last open 2 will be merged shortly (reviews are done and good to go).

Detail

This Pull Request adds a summary of the notable changes to the SQLite3 adapter to the release notes

@rails-bot rails-bot bot added the docs label Sep 26, 2023
Copy link
Member

@skipkayhil skipkayhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove skip ci from the commit message? (Putting it in the PR title but not the commit message will run Github Actions and not Buildkite, which is what we want)

The text looks good but I'll wait for the other PRs to be merged 👍

@fractaledmind fractaledmind changed the title Add 7.1 release notes for SQLite3 adapter improvements [skip ci] Add 7.1 release notes for SQLite3 adapter improvements Sep 26, 2023
@fractaledmind
Copy link
Contributor Author

@skipkayhil Done

@rafaelfranca rafaelfranca merged commit 15ccf5b into rails:main Sep 26, 2023
3 of 4 checks passed
@fractaledmind fractaledmind deleted the ar-sqlite-7_1-release-notes branch September 26, 2023 16:16
@yahonda
Copy link
Member

yahonda commented Sep 29, 2023

generated columns #49346 and defrered foregn keys #49376 are open and they are not merged to main (yet), so at least the 7.1 release note should not include them.

@rafaelfranca
Copy link
Member

Fixed in 8d2c455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants