Ensure system test scaffold supports datetime and time attributes
#49409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Sep 27, 2023
railties/lib/rails/generators/test_unit/scaffold/templates/system_test.rb.tt
Outdated
Show resolved
Hide resolved
Prior to this commit, system tests generated by a scaffold containing `time` or `datetime` attributes would fail during the update test. The captured screenshot would reveal the following client-side validation errors. ``` Please enter a valid value. The two nearest valid values are 10:45:33 AM and 10:46:33 AM. ``` ``` Please enter a valid value. The two nearest valid values are 09/27/2023, 10:45:33 AM and 09/27/2023, 10:46:33 AM. ``` Converting the values to a string ensures they are entered correctly and that the tests pass.
stevepolitodesign
force-pushed
the
sp-datetime-local-scaffold
branch
from
a8d8edc
to
d0d1a1b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Prior to this commit, system tests generated by a scaffold containing
timeordatetimeattributes would fail during the update test. The captured screenshot would reveal the following client-side validation errors.Detail
This Pull Request updates the system test scaffold by conditionally converting
timeanddatetimevalues to a string to ensures they are entered correctly and that the tests pass.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]